diff options
| author | Mika Kukkonen <mikukkon@gmail.com> | 2005-09-07 00:17:17 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-09-08 01:57:28 +0200 |
| commit | 230649da7cb73914b8b2a1ffc802a2951e970454 (patch) | |
| tree | ea18d1246118221640d1aebc89d6f1ba11b4869c /kernel/workqueue.c | |
| parent | [PATCH] fsnotify: hook on removexattr, too (diff) | |
| download | linux-230649da7cb73914b8b2a1ffc802a2951e970454.tar.xz linux-230649da7cb73914b8b2a1ffc802a2951e970454.zip | |
[PATCH] create_workqueue_thread() signedness fix
With "-W -Wno-unused -Wno-sign-compare" I get the following compile warning:
CC kernel/workqueue.o
kernel/workqueue.c: In function `workqueue_cpu_callback':
kernel/workqueue.c:504: warning: ordered comparison of pointer with integer zero
On error create_workqueue_thread() returns NULL, not negative pointer, so
following trivial patch suggests itself.
Signed-off-by: Mika Kukkonen <mikukkon@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel/workqueue.c')
| -rw-r--r-- | kernel/workqueue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index c7e36d4a70ca..a3de837a8ddd 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -499,7 +499,7 @@ static int __devinit workqueue_cpu_callback(struct notifier_block *nfb, case CPU_UP_PREPARE: /* Create a new workqueue thread for it. */ list_for_each_entry(wq, &workqueues, list) { - if (create_workqueue_thread(wq, hotcpu) < 0) { + if (!create_workqueue_thread(wq, hotcpu)) { printk("workqueue for %i failed\n", hotcpu); return NOTIFY_BAD; } |