diff options
| author | Lai Jiangshan <laijs@linux.alibaba.com> | 2021-12-07 08:35:39 +0100 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2021-12-09 23:16:08 +0100 |
| commit | 11b45b0bf402b53c94c86737a440363fc36f03cd (patch) | |
| tree | 7d99333c15fe2b219065cd264bc0d22fc734d2ae /kernel/workqueue.c | |
| parent | workqueue: Remove the advanced kicking of the idle workers in rebind_workers() (diff) | |
| download | linux-11b45b0bf402b53c94c86737a440363fc36f03cd.tar.xz linux-11b45b0bf402b53c94c86737a440363fc36f03cd.zip | |
workqueue: Remove outdated comment about exceptional workers in unbind_workers()
Long time before, workers are not ALL bound after CPU_ONLINE, they can
still be running in other CPUs before self rebinding.
But the commit a9ab775bcadf ("workqueue: directly restore CPU affinity
of workers from CPU_ONLINE") makes rebind_workers() bind them all.
So all workers are on the CPU before the CPU is down.
And the comment in unbind_workers() refers to the workers "which are
still executing works from before the last CPU down" is outdated.
Just removed it.
Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/workqueue.c')
| -rw-r--r-- | kernel/workqueue.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index f7f4a5fc7736..ae58c6ace23f 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -4978,9 +4978,7 @@ static void unbind_workers(int cpu) /* * We've blocked all attach/detach operations. Make all workers * unbound and set DISASSOCIATED. Before this, all workers - * except for the ones which are still executing works from - * before the last CPU down must be on the cpu. After - * this, they may become diasporas. + * must be on the cpu. After this, they may become diasporas. */ for_each_pool_worker(worker, pool) worker->flags |= WORKER_UNBOUND; |