diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2011-02-02 23:58:19 +0100 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2011-02-19 12:58:08 +0100 |
| commit | b738a50a202639614c98b5763b01bf9201779e50 (patch) | |
| tree | fa1f0314db4d1a7d6a482d5845da2ffa1d99dd73 /kernel | |
| parent | genirq: Plug race in report_bad_irq() (diff) | |
| download | linux-b738a50a202639614c98b5763b01bf9201779e50.tar.xz linux-b738a50a202639614c98b5763b01bf9201779e50.zip | |
genirq: Warn when handler enables interrupts
We run all handlers with interrupts disabled and expect them not to
enable them. Warn when we catch one who does.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/irq/handle.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c index 3540a7190122..cdd6fbbe771c 100644 --- a/kernel/irq/handle.c +++ b/kernel/irq/handle.c @@ -68,6 +68,9 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action) ret = action->handler(irq, action->dev_id); trace_irq_handler_exit(irq, action, ret); + if (WARN_ON_ONCE(!irqs_disabled())) + local_irq_disable(); + switch (ret) { case IRQ_WAKE_THREAD: /* @@ -114,7 +117,6 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action) if (status & IRQF_SAMPLE_RANDOM) add_interrupt_randomness(irq); - local_irq_disable(); return retval; } |