summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorAndrea Righi <righi.andrea@gmail.com>2009-02-05 00:12:03 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2009-02-05 21:56:46 +0100
commit1f5e31d7e55ac7fbd4ec5e5b20c8868b0e4564c9 (patch)
tree713d0ace63c95da9b989aafce8ec84ebb1d1cbc3 /kernel
parentrtc: rtc-dm355evm driver (diff)
downloadlinux-1f5e31d7e55ac7fbd4ec5e5b20c8868b0e4564c9.tar.xz
linux-1f5e31d7e55ac7fbd4ec5e5b20c8868b0e4564c9.zip
fbmem: don't call copy_from/to_user() with mutex held
Avoid calling copy_from/to_user() with fb_info->lock mutex held in fbmem ioctl(). fb_mmap() is called under mm->mmap_sem (A) held, that also acquires fb_info->lock (B); fb_ioctl() takes fb_info->lock (B) and does copy_from/to_user() that might acquire mm->mmap_sem (A), causing a deadlock. NOTE: it doesn't push down the fb_info->lock in each own driver's fb_ioctl(), so there are still potential deadlocks elsewhere. Signed-off-by: Andrea Righi <righi.andrea@gmail.com> Cc: Dave Jones <davej@redhat.com> Cc: "Rafael J. Wysocki" <rjw@sisk.pl> Cc: Johannes Weiner <hannes@saeurebad.de> Cc: Krzysztof Helt <krzysztof.h1@wp.pl> Cc: Harvey Harrison <harvey.harrison@gmail.com> Cc: Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions