diff options
| author | Jason Low <jason.low2@hp.com> | 2015-02-13 04:58:07 +0100 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2015-03-02 17:55:04 +0100 |
| commit | 283cb41f426b723a0255702b761b0fc5d1b53a81 (patch) | |
| tree | 269caf80d8733b12ab9542b10395dd98181e6791 /kernel | |
| parent | cpuset: fix a warning when clearing configured masks in old hierarchy (diff) | |
| download | linux-283cb41f426b723a0255702b761b0fc5d1b53a81.tar.xz linux-283cb41f426b723a0255702b761b0fc5d1b53a81.zip | |
cpuset: Fix cpuset sched_relax_domain_level
The cpuset.sched_relax_domain_level can control how far we do
immediate load balancing on a system. However, it was found on recent
kernels that echo'ing a value into cpuset.sched_relax_domain_level
did not reduce any immediate load balancing.
The reason this occurred was because the update_domain_attr_tree() traversal
did not update for the "top_cpuset". This resulted in nothing being changed
when modifying the sched_relax_domain_level parameter.
This patch is able to address that problem by having update_domain_attr_tree()
allow updates for the root in the cpuset traversal.
Fixes: fc560a26acce ("cpuset: replace cpuset->stack_list with cpuset_for_each_descendant_pre()")
Cc: <stable@vger.kernel.org> # 3.9+
Signed-off-by: Jason Low <jason.low2@hp.com>
Signed-off-by: Zefan Li <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Tested-by: Serge Hallyn <serge.hallyn@canonical.com>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/cpuset.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/kernel/cpuset.c b/kernel/cpuset.c index 407611ba371b..fc7f4748d34a 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c @@ -548,9 +548,6 @@ static void update_domain_attr_tree(struct sched_domain_attr *dattr, rcu_read_lock(); cpuset_for_each_descendant_pre(cp, pos_css, root_cs) { - if (cp == root_cs) - continue; - /* skip the whole subtree if @cp doesn't have any CPU */ if (cpumask_empty(cp->cpus_allowed)) { pos_css = css_rightmost_descendant(pos_css); |