diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2015-01-19 23:37:04 +0100 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2015-01-20 02:08:31 +0100 |
| commit | c772be52319de9756fd82f36d37a6d3e003441e3 (patch) | |
| tree | ea48a4ea309a0f9c69dbf0949b52a8a763585156 /kernel | |
| parent | param: initialize store function to NULL if not available. (diff) | |
| download | linux-c772be52319de9756fd82f36d37a6d3e003441e3.tar.xz linux-c772be52319de9756fd82f36d37a6d3e003441e3.zip | |
param: fix uninitialized read with CONFIG_DEBUG_LOCK_ALLOC
ignore_lockdep is uninitialized, and sysfs_attr_init() doesn't initialize
it, so memset to 0.
Reported-by: Huang Ying <ying.huang@intel.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/params.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/params.c b/kernel/params.c index bd65d136a470..728e05b167de 100644 --- a/kernel/params.c +++ b/kernel/params.c @@ -642,6 +642,7 @@ static __modinit int add_sysfs_param(struct module_kobject *mk, mk->mp->grp.attrs = new_attrs; /* Tack new one on the end. */ + memset(&mk->mp->attrs[mk->mp->num], 0, sizeof(mk->mp->attrs[0])); sysfs_attr_init(&mk->mp->attrs[mk->mp->num].mattr.attr); mk->mp->attrs[mk->mp->num].param = kp; mk->mp->attrs[mk->mp->num].mattr.show = param_attr_show; |