summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorEric Paris <eparis@redhat.com>2014-01-14 03:16:59 +0100
committerEric Paris <eparis@redhat.com>2014-01-14 04:33:41 +0100
commit1ce319f11ccc5ee5ed1bc1e020f1ac6e6d689c74 (patch)
treef3ea9e05a746a629d2c55c41ca2f0d2b4ecdbe0c /kernel
parentaudit: rework AUDIT_TTY_SET to only grab spin_lock once (diff)
downloadlinux-1ce319f11ccc5ee5ed1bc1e020f1ac6e6d689c74.tar.xz
linux-1ce319f11ccc5ee5ed1bc1e020f1ac6e6d689c74.zip
audit: reorder AUDIT_TTY_SET arguments
An admin is likely to want to see old and new values next to each other. Putting all of the old values followed by all of the new values is just hard to read as a human. Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/audit.c11
1 files changed, 4 insertions, 7 deletions
diff --git a/kernel/audit.c b/kernel/audit.c
index b1d24a035ec9..9daf24361d53 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1010,13 +1010,10 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
spin_unlock(&tsk->sighand->siglock);
audit_log_common_recv_msg(&ab, AUDIT_CONFIG_CHANGE);
- audit_log_format(ab, " op=tty_set"
- " old-enabled=%d old-log_passwd=%d"
- " new-enabled=%d new-log_passwd=%d"
- " res=%d",
- old.enabled, old.log_passwd,
- s.enabled, s.log_passwd,
- !err);
+ audit_log_format(ab, " op=tty_set old-enabled=%d new-enabled=%d"
+ " old-log_passwd=%d new-log_passwd=%d res=%d",
+ old.enabled, s.enabled, old.log_passwd,
+ s.log_passwd, !err);
audit_log_end(ab);
break;
}