summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorDaniel Thompson <daniel.thompson@linaro.org>2020-05-06 18:42:23 +0200
committerDaniel Thompson <daniel.thompson@linaro.org>2020-05-07 16:12:27 +0200
commit3fec4aecb311995189217e64d725cfe84a568de3 (patch)
tree2f5e9d9bcb2fe20a664fc26f9683f06117374fde /kernel
parentLinux 5.7-rc3 (diff)
downloadlinux-3fec4aecb311995189217e64d725cfe84a568de3.tar.xz
linux-3fec4aecb311995189217e64d725cfe84a568de3.zip
kgdb: Fix spurious true from in_dbg_master()
Currently there is a small window where a badly timed migration could cause in_dbg_master() to spuriously return true. Specifically if we migrate to a new core after reading the processor id and the previous core takes a breakpoint then we will evaluate true if we read kgdb_active before we get the IPI to bring us to halt. Fix this by checking irqs_disabled() first. Interrupts are always disabled when we are executing the kgdb trap so this is an acceptable prerequisite. This also allows us to replace raw_smp_processor_id() with smp_processor_id() since the short circuit logic will prevent warnings from PREEMPT_DEBUG. Fixes: dcc7871128e9 ("kgdb: core changes to support kdb") Suggested-by: Will Deacon <will@kernel.org> Link: https://lore.kernel.org/r/20200506164223.2875760-1-daniel.thompson@linaro.org Reviewed-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions