diff options
| author | Dale Farnsworth <dale@farnsworth.org> | 2008-02-25 23:03:02 +0100 |
|---|---|---|
| committer | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2008-02-25 23:03:02 +0100 |
| commit | 1481197b50114d7212d659d41cb97f31a8934883 (patch) | |
| tree | c3ad3133cef46f64d3a6dbb9773591bcf29b87f9 /kernel | |
| parent | lockdep: increase MAX_LOCK_DEPTH (diff) | |
| download | linux-1481197b50114d7212d659d41cb97f31a8934883.tar.xz linux-1481197b50114d7212d659d41cb97f31a8934883.zip | |
Subject: lockdep: include all lock classes in all_lock_classes
Add each lock class to the all_lock_classes list when it is
first registered.
Previously, lock classes were added to all_lock_classes when
the lock class was first used. Since one of the uses of the
list is to find unused locks, this didn't work well.
Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/lockdep.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/kernel/lockdep.c b/kernel/lockdep.c index 3574379f4d62..81a4e4a3f087 100644 --- a/kernel/lockdep.c +++ b/kernel/lockdep.c @@ -779,6 +779,10 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force) * parallel walking of the hash-list safe: */ list_add_tail_rcu(&class->hash_entry, hash_head); + /* + * Add it to the global list of classes: + */ + list_add_tail_rcu(&class->lock_entry, &all_lock_classes); if (verbose(class)) { graph_unlock(); @@ -2282,10 +2286,6 @@ static int mark_lock(struct task_struct *curr, struct held_lock *this, return 0; break; case LOCK_USED: - /* - * Add it to the global list of classes: - */ - list_add_tail_rcu(&this->class->lock_entry, &all_lock_classes); debug_atomic_dec(&nr_unused_locks); break; default: |