diff options
author | André Goddard Rosa <andre.goddard@gmail.com> | 2009-12-15 03:01:01 +0100 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-12-15 17:53:32 +0100 |
commit | 922ac25c9f4b5dc4c48ff12bfd14a98bdeb6ff0a (patch) | |
tree | 8c467994a89e65b231a3905a5e9d309ff1833139 /lib/bust_spinlocks.c | |
parent | vsprintf: factor out skip_space code in a separate function (diff) | |
download | linux-922ac25c9f4b5dc4c48ff12bfd14a98bdeb6ff0a.tar.xz linux-922ac25c9f4b5dc4c48ff12bfd14a98bdeb6ff0a.zip |
vsprintf: reuse almost identical simple_strtoulX() functions
The difference between simple_strtoul() and simple_strtoull() is just
the size of the variable used to keep track of the sum of characters
converted to numbers:
unsigned long simple_strtoul() {...}
unsigned long long simple_strtoull(){...}
Both are same size on my Core 2/gcc 4.4.1.
Overflow condition is not checked on both functions, so an extremely large
string can break these functions so that they don't even notice it.
As we do not care for overflowing on these functions, always keep the sum
using the larger variable around (unsigned long long) on simple_strtoull()
and cast it to (unsigned long) on simple_strtoul(), which then becomes
just a wrapper around simple_strtoull().
Code size decreases by 304 bytes:
text data bss dec hex filename
15534 0 8 15542 3cb6 vsprintf.o (ex lib/lib.a-BEFORE)
15230 0 8 15238 3b86 vsprintf.o (ex lib/lib.a-AFTER)
Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/bust_spinlocks.c')
0 files changed, 0 insertions, 0 deletions