diff options
author | Ming Lei <ming.lei@canoical.com> | 2014-09-17 11:47:58 +0200 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2014-09-22 20:00:07 +0200 |
commit | 2edd2c740b2918eb0a9a1fe1b69678b903769ec2 (patch) | |
tree | 36df228ed4b404fdf1b53b966ccc914ad5555df3 /lib/crc32defs.h | |
parent | blk-mq: pass a reserved argument to the timeout handler (diff) | |
download | linux-2edd2c740b2918eb0a9a1fe1b69678b903769ec2.tar.xz linux-2edd2c740b2918eb0a9a1fe1b69678b903769ec2.zip |
blk-mq: remove unnecessary blk_clear_rq_complete()
This patch removes two unnecessary blk_clear_rq_complete(),
the REQ_ATOM_COMPLETE flag is cleared inside blk_mq_start_request(),
so:
- The blk_clear_rq_complete() in blk_flush_restore_request()
needn't because the request will be freed later, and clearing
it here may open a small race window with timeout.
- The blk_clear_rq_complete() in blk_mq_requeue_request() isn't
necessary too, even though REQ_ATOM_STARTED is cleared in
__blk_mq_requeue_request(), in theory it still may cause a small
race window with timeout since the two clear_bit() may be
reordered.
Signed-off-by: Ming Lei <ming.lei@canoical.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'lib/crc32defs.h')
0 files changed, 0 insertions, 0 deletions