diff options
author | Shay Drory <shayd@nvidia.com> | 2021-02-25 11:27:53 +0100 |
---|---|---|
committer | Saeed Mahameed <saeedm@nvidia.com> | 2021-06-10 02:20:05 +0200 |
commit | 7a545077cb6701957e84c7f158630bb5c984e648 (patch) | |
tree | 69e9afb87043f36a51948f79b171969b8db30e02 /lib/errseq.c | |
parent | net/mlx5e: Fix select queue to consider SKBTX_HW_TSTAMP (diff) | |
download | linux-7a545077cb6701957e84c7f158630bb5c984e648.tar.xz linux-7a545077cb6701957e84c7f158630bb5c984e648.zip |
Revert "net/mlx5: Arm only EQs with EQEs"
In the scenario described below, an EQ can remain in FIRED state which
can result in missing an interrupt generation.
The scenario:
device mlx5_core driver
------ ----------------
EQ1.eqe generated
EQ1.MSI-X sent
EQ1.state = FIRED
EQ2.eqe generated
mlx5_irq()
polls - eq1_eqes()
arm eq1
polls - eq2_eqes()
arm eq2
EQ2.MSI-X sent
EQ2.state = FIRED
mlx5_irq()
polls - eq2_eqes() -- no eqes found
driver skips EQ arming;
->EQ2 remains fired, misses generating interrupt.
Hence, always arm the EQ by reverting the cited commit in fixes tag.
Fixes: d894892dda25 ("net/mlx5: Arm only EQs with EQEs")
Signed-off-by: Shay Drory <shayd@nvidia.com>
Reviewed-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Diffstat (limited to 'lib/errseq.c')
0 files changed, 0 insertions, 0 deletions