diff options
author | Rob Herring <robh@kernel.org> | 2018-05-03 20:09:44 +0200 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2018-05-04 01:09:02 +0200 |
commit | bc519d9574618e47a0c788000fb78da95e18d953 (patch) | |
tree | c1405de627823cde094254b4a65817d73c14a06a /lib/inflate.c | |
parent | spi: bcm-qspi: Always read and set BSPI_MAST_N_BOOT_CTRL (diff) | |
download | linux-bc519d9574618e47a0c788000fb78da95e18d953.tar.xz linux-bc519d9574618e47a0c788000fb78da95e18d953.zip |
spi: bcm2835aux: ensure interrupts are enabled for shared handler
The BCM2835 AUX SPI has a shared interrupt line (with AUX UART).
Downstream fixes this with an AUX irqchip to demux the IRQ sources and a
DT change which breaks compatibility with older kernels. The AUX irqchip
was already rejected for upstream[1] and the DT change would break
working systems if the DTB is updated to a newer one. The latter issue
was brought to my attention by Alex Graf.
The root cause however is a bug in the shared handler. Shared handlers
must check that interrupts are actually enabled before servicing the
interrupt. Add a check that the TXEMPTY or IDLE interrupts are enabled.
[1] https://patchwork.kernel.org/patch/9781221/
Cc: Alexander Graf <agraf@suse.de>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Eric Anholt <eric@anholt.net>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-spi@vger.kernel.org
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'lib/inflate.c')
0 files changed, 0 insertions, 0 deletions