summaryrefslogtreecommitdiffstats
path: root/lib/kstrtox.h
diff options
context:
space:
mode:
authorDan Streetman <ddstreet@ieee.org>2017-02-27 23:26:53 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2017-02-28 03:43:45 +0100
commitfd5bb66cd934987e49557455b6497fc006521940 (patch)
treed238fc3900b464c335b8719703ee1bfd9743c719 /lib/kstrtox.h
parentzswap: clear compressor or zpool param if invalid at init (diff)
downloadlinux-fd5bb66cd934987e49557455b6497fc006521940.tar.xz
linux-fd5bb66cd934987e49557455b6497fc006521940.zip
zswap: don't param_set_charp while holding spinlock
Change the zpool/compressor param callback function to release the zswap_pools_lock spinlock before calling param_set_charp, since that function may sleep when it calls kmalloc with GFP_KERNEL. While this problem has existed for a while, I wasn't able to trigger it using a tight loop changing either/both the zpool and compressor params; I think it's very unlikely to be an issue on the stable kernels, especially since most zswap users will change the compressor and/or zpool from sysfs only one time each boot - or zero times, if they add the params to the kernel boot. Fixes: c99b42c3529e ("zswap: use charp for zswap param strings") Link: http://lkml.kernel.org/r/20170126155821.4545-1-ddstreet@ieee.org Signed-off-by: Dan Streetman <dan.streetman@canonical.com> Reported-by: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> Cc: Michal Hocko <mhocko@kernel.org> Cc: Minchan Kim <minchan@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/kstrtox.h')
0 files changed, 0 insertions, 0 deletions