summaryrefslogtreecommitdiffstats
path: root/lib/objagg.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2019-02-13 09:56:50 +0100
committerDavid S. Miller <davem@davemloft.net>2019-02-14 07:13:29 +0100
commit4446eb8dbeb223031fb652dd1e58e59d3d4b4aba (patch)
tree1f482431de21a4480dcb6accb19886058f160e46 /lib/objagg.c
parentcxgb4vf: Few more link management changes. (diff)
downloadlinux-4446eb8dbeb223031fb652dd1e58e59d3d4b4aba.tar.xz
linux-4446eb8dbeb223031fb652dd1e58e59d3d4b4aba.zip
lib: objagg: Fix an error code in objagg_hints_get()
We need to set the error code on this path otherwise we return ERR_PTR(0) which would result in a NULL dereference in the caller. Fixes: 9069a3817d82 ("lib: objagg: implement optimization hints assembly and use hints for object creation") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib/objagg.c')
-rw-r--r--lib/objagg.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/objagg.c b/lib/objagg.c
index 781f41c3c47d..d552ec9c60ed 100644
--- a/lib/objagg.c
+++ b/lib/objagg.c
@@ -968,8 +968,10 @@ struct objagg_hints *objagg_hints_get(struct objagg *objagg,
if (err)
goto err_fillup_hints;
- if (WARN_ON(objagg_hints->node_count != objagg->obj_count))
+ if (WARN_ON(objagg_hints->node_count != objagg->obj_count)) {
+ err = -EINVAL;
goto err_node_count_check;
+ }
return objagg_hints;