diff options
author | Wang Nan <wangnan0@huawei.com> | 2015-08-26 12:57:42 +0200 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-08-26 15:36:04 +0200 |
commit | 614e2fdbd79b47ddf63a1ccd3f2343e98c3077fb (patch) | |
tree | f601dce7cfbaf4bfe90ab992bb5e68342168c0d9 /lib/percpu_test.c | |
parent | tools build: Allow duplicate objects in the object list (diff) | |
download | linux-614e2fdbd79b47ddf63a1ccd3f2343e98c3077fb.tar.xz linux-614e2fdbd79b47ddf63a1ccd3f2343e98c3077fb.zip |
perf probe: Fix list result when symbol can't be found
'perf probe -l' reports error if it is unable find symbol through
address. Here is an example.
# echo 'p:probe_libc/abs_5 /lib64/libc.so.6:0x5' >
/sys/kernel/debug/tracing/uprobe_events
# cat /sys/kernel/debug/tracing/uprobe_events
p:probe_libc/abs_5 /lib64/libc.so.6:0x0000000000000005
# perf probe -l
Error: Failed to show event list
Also, this situation triggers a logical inconsistency in
convert_to_perf_probe_point() that, it returns ENOMEM but actually it
never try strdup().
This patch removes !tp->module && !is_kprobe condition, so it always
uses address to build function name if symbol not found.
Test result:
# perf probe -l
probe_libc:abs_5 (on 0x5 in /lib64/libc.so.6)
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1440586666-235233-4-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'lib/percpu_test.c')
0 files changed, 0 insertions, 0 deletions