summaryrefslogtreecommitdiffstats
path: root/lib/ratelimit.c
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2012-09-07 17:30:32 +0200
committerNicholas Bellinger <nab@linux-iscsi.org>2012-09-07 20:04:08 +0200
commit306c11b28d7bb85a7adda741798a2b6b60dd305a (patch)
tree65639a992a1bf2ec8abc1836f935b0e67d634da5 /lib/ratelimit.c
parenttarget: fix use-after-free with PSCSI sense data (diff)
downloadlinux-306c11b28d7bb85a7adda741798a2b6b60dd305a.tar.xz
linux-306c11b28d7bb85a7adda741798a2b6b60dd305a.zip
target: go through normal processing for zero-length PSCSI commands
Right now, commands with a zero-size payload are skipped completely. This is wrong; such commands should be passed down to the device and processed normally. For physical backends, this ignores completely things such as START STOP UNIT. For virtual backends, we have a hack in place to clear a unit attention state on a zero-size REQUEST SENSE, but we still do not report errors properly on zero-length commands---out-of-bounds 0-block reads and writes, too small parameter list lengths, etc. This patch fixes this for PSCSI. Uses of transport_kmap_data_sg are guarded with a check for non-zero cmd->data_length; for all other commands a zero length is handled properly in pscsi_execute_cmd. The sole exception will be for now REPORT LUNS, which is handled through the normal SPC emulation. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'lib/ratelimit.c')
0 files changed, 0 insertions, 0 deletions