diff options
author | Peter Zijlstra <peterz@infradead.org> | 2022-04-08 11:45:53 +0200 |
---|---|---|
committer | Peter Zijlstra <peterz@infradead.org> | 2022-04-19 21:58:47 +0200 |
commit | 226d44acf6dfe71c9df5804b82364e93cf908b53 (patch) | |
tree | 13ec221fd203a3ac03fe7e42459ee5bec67f7e88 /lib/strncpy_from_user.c | |
parent | MAINTAINERS: Add x86 unwinding entry (diff) | |
download | linux-226d44acf6dfe71c9df5804b82364e93cf908b53.tar.xz linux-226d44acf6dfe71c9df5804b82364e93cf908b53.zip |
lib/strn*,objtool: Enforce user_access_begin() rules
Apparently GCC can fail to inline a 'static inline' single caller
function:
lib/strnlen_user.o: warning: objtool: strnlen_user()+0x33: call to do_strnlen_user() with UACCESS enabled
lib/strncpy_from_user.o: warning: objtool: strncpy_from_user()+0x33: call to do_strncpy_from_user() with UACCESS enabled
Reported-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lore.kernel.org/r/20220408094718.262932488@infradead.org
Diffstat (limited to 'lib/strncpy_from_user.c')
-rw-r--r-- | lib/strncpy_from_user.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/strncpy_from_user.c b/lib/strncpy_from_user.c index 08fc72d3ed16..6432b8c3e431 100644 --- a/lib/strncpy_from_user.c +++ b/lib/strncpy_from_user.c @@ -25,7 +25,7 @@ * hit it), 'max' is the address space maximum (and we return * -EFAULT if we hit it). */ -static inline long do_strncpy_from_user(char *dst, const char __user *src, +static __always_inline long do_strncpy_from_user(char *dst, const char __user *src, unsigned long count, unsigned long max) { const struct word_at_a_time constants = WORD_AT_A_TIME_CONSTANTS; |