diff options
| author | Alexander Shishkin <alexander.shishkin@linux.intel.com> | 2018-10-16 13:13:40 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-10-16 13:45:44 +0200 |
| commit | 93048c0944150b316a15f92c41a4d626c8df37fd (patch) | |
| tree | 0f226cb0985cb48fc52e13eca3fed13bceefa9e2 /lib/test_memcat_p.c | |
| parent | MAINTAINERS: Clarify UIO vs UIOVEC maintainer (diff) | |
| download | linux-93048c0944150b316a15f92c41a4d626c8df37fd.tar.xz linux-93048c0944150b316a15f92c41a4d626c8df37fd.zip | |
lib: Fix ia64 bootloader linkage
kbuild robot reports that since commit ce76d938dd98 ("lib: Add memcat_p():
paste 2 pointer arrays together") the ia64/hp/sim/boot fails to link:
> LD arch/ia64/hp/sim/boot/bootloader
> lib/string.o: In function `__memcat_p':
> string.c:(.text+0x1f22): undefined reference to `__kmalloc'
> string.c:(.text+0x1ff2): undefined reference to `__kmalloc'
> make[1]: *** [arch/ia64/hp/sim/boot/Makefile:37: arch/ia64/hp/sim/boot/bootloader] Error 1
The reason is, the above commit, via __memcat_p(), adds a call to
__kmalloc to string.o, which happens to be used in the bootloader, but
there's no kmalloc or slab or anything.
Since the linker would only pull in objects that contain referenced
symbols, moving __memcat_p() to a different compilation unit solves the
problem.
Fixes: ce76d938dd98 ("lib: Add memcat_p(): paste 2 pointer arrays together")
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Reported-by: kbuild test robot <lkp@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/test_memcat_p.c')
| -rw-r--r-- | lib/test_memcat_p.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/test_memcat_p.c b/lib/test_memcat_p.c index 2b163a749ecb..849c477d49d0 100644 --- a/lib/test_memcat_p.c +++ b/lib/test_memcat_p.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Test cases for memcat_p() in lib/string.c + * Test cases for memcat_p() in lib/memcat_p.c */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt |