diff options
| author | NeilBrown <neilb@suse.com> | 2018-06-18 04:52:50 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-06-22 06:43:27 +0200 |
| commit | cbab901296232b1247b46e6e127103d2f738d783 (patch) | |
| tree | 0e257d10be56b4b0bb163212cdc78f082688470e /lib/test_rhashtable.c | |
| parent | VSOCK: fix loopback on big-endian systems (diff) | |
| download | linux-cbab901296232b1247b46e6e127103d2f738d783.tar.xz linux-cbab901296232b1247b46e6e127103d2f738d783.zip | |
rhashtable: silence RCU warning in rhashtable_test.
print_ht in rhashtable_test calls rht_dereference() with neither
RCU protection or the mutex. This triggers an RCU warning.
So take the mutex to silence the warning.
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib/test_rhashtable.c')
| -rw-r--r-- | lib/test_rhashtable.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c index fb6968109113..6ca59ffcacbe 100644 --- a/lib/test_rhashtable.c +++ b/lib/test_rhashtable.c @@ -501,6 +501,8 @@ static unsigned int __init print_ht(struct rhltable *rhlt) unsigned int i, cnt = 0; ht = &rhlt->ht; + /* Take the mutex to avoid RCU warning */ + mutex_lock(&ht->mutex); tbl = rht_dereference(ht->tbl, ht); for (i = 0; i < tbl->size; i++) { struct rhash_head *pos, *next; @@ -534,6 +536,7 @@ static unsigned int __init print_ht(struct rhltable *rhlt) } } printk(KERN_ERR "\n---- ht: ----%s\n-------------\n", buff); + mutex_unlock(&ht->mutex); return cnt; } |