diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2008-11-25 00:29:20 +0100 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2008-11-26 07:58:29 +0100 |
| commit | 1224e376f2a7e3c7ab19ef37099a78597978a696 (patch) | |
| tree | 244bbf8c345ac70487ddcb6283c7895f6cbdb7dd /lib | |
| parent | sched: convert local_cpu_mask to cpumask_var_t, fix (diff) | |
| download | linux-1224e376f2a7e3c7ab19ef37099a78597978a696.tar.xz linux-1224e376f2a7e3c7ab19ef37099a78597978a696.zip | |
sched: avoid stack var in move_task_off_dead_cpu, fix
Impact: locking fix
We can't call cpuset_cpus_allowed_locked() with the rq lock held.
However, the rq lock merely protects us from (1) cpu_online_mask changing
and (2) someone else changing p->cpus_allowed.
The first can't happen because we're being called from a cpu hotplug
notifier. The second doesn't really matter: we are forcing the task off
a CPU it was affine to, so we're not doing very well anyway.
So we remove the rq lock from this path, and all is good.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Mike Travis <travis@sgi.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions