diff options
| author | Julia Lawall <julia@diku.dk> | 2009-09-24 00:57:36 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-09-24 16:21:05 +0200 |
| commit | 3354f73b24c6d392ed7fd5583cfcc7604c1934ae (patch) | |
| tree | b1c72139bef6d31eebcc72af5634f303c5242e69 /lib | |
| parent | fs/romfs: correct error-handling code (diff) | |
| download | linux-3354f73b24c6d392ed7fd5583cfcc7604c1934ae.tar.xz linux-3354f73b24c6d392ed7fd5583cfcc7604c1934ae.zip | |
drivers/vlynq/vlynq.c: fix resource size off by 1 error
In this case, the calls to request_mem_region, ioremap, and
release_mem_region all have a consistent length argument, len, but since
in other files (res->end - res->start) + 1, equivalent to
resource_size(res), is used for a resource-typed structure res, one could
consider whether the same should be done here.
The problem was found using the following semantic patch:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
struct resource *res;
@@
- (res->end - res->start) + 1
+ resource_size(res)
@@
struct resource *res;
@@
- res->end - res->start
+ BAD(resource_size(res))
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions