summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorEric Biggers <ebiggers@google.com>2020-05-02 20:24:27 +0200
committerHerbert Xu <herbert@gondor.apana.org.au>2020-05-08 07:32:17 +0200
commit228c4f265c6eb60eaa4ed0edb3bf7c113173576c (patch)
treeaf8e07c49d95c2a4fe460d1ec59c3c215a314cd7 /lib
parentcrypto: lib/sha1 - remove unnecessary includes of linux/cryptohash.h (diff)
downloadlinux-228c4f265c6eb60eaa4ed0edb3bf7c113173576c.tar.xz
linux-228c4f265c6eb60eaa4ed0edb3bf7c113173576c.zip
crypto: lib/sha1 - fold linux/cryptohash.h into crypto/sha.h
<linux/cryptohash.h> sounds very generic and important, like it's the header to include if you're doing cryptographic hashing in the kernel. But actually it only includes the library implementation of the SHA-1 compression function (not even the full SHA-1). This should basically never be used anymore; SHA-1 is no longer considered secure, and there are much better ways to do cryptographic hashing in the kernel. Remove this header and fold it into <crypto/sha.h> which already contains constants and functions for SHA-1 (along with SHA-2). Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'lib')
-rw-r--r--lib/sha1.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/sha1.c b/lib/sha1.c
index b381e8cd4fe4..49257a915bb6 100644
--- a/lib/sha1.c
+++ b/lib/sha1.c
@@ -9,7 +9,7 @@
#include <linux/kernel.h>
#include <linux/export.h>
#include <linux/bitops.h>
-#include <linux/cryptohash.h>
+#include <crypto/sha.h>
#include <asm/unaligned.h>
/*