diff options
| author | Roman Smirnov <r.smirnov@omp.ru> | 2024-03-07 08:17:17 +0100 |
|---|---|---|
| committer | Andrew Morton <akpm@linux-foundation.org> | 2024-03-12 21:09:23 +0100 |
| commit | bea0a58695870295a315cec15a9fea6f40fe5ff3 (patch) | |
| tree | 28df0d73195952dbcb3220f6dd19747c444fc557 /lib | |
| parent | buildid: use kmap_local_page() (diff) | |
| download | linux-bea0a58695870295a315cec15a9fea6f40fe5ff3.tar.xz linux-bea0a58695870295a315cec15a9fea6f40fe5ff3.zip | |
assoc_array: fix the return value in assoc_array_insert_mid_shortcut()
Returning the edit variable is redundant because it is dereferenced right
before it is returned. It would be better to return true.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Link: https://lkml.kernel.org/r/20240307071717.5318-1-r.smirnov@omp.ru
Signed-off-by: Roman Smirnov <r.smirnov@omp.ru>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/assoc_array.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/assoc_array.c b/lib/assoc_array.c index ca0b4f360c1a..388e656ac974 100644 --- a/lib/assoc_array.c +++ b/lib/assoc_array.c @@ -938,7 +938,7 @@ static bool assoc_array_insert_mid_shortcut(struct assoc_array_edit *edit, edit->leaf_p = &new_n0->slots[0]; pr_devel("<--%s() = ok [split shortcut]\n", __func__); - return edit; + return true; } /** |