diff options
| author | Dwaipayan Ray <dwaipayanray1@gmail.com> | 2021-07-16 13:28:52 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2021-08-01 19:39:17 +0200 |
| commit | 33529018294f1eabc6b5bb2672941165e658e96a (patch) | |
| tree | f68caaefd73dd4f2c9fc3948cabe60eb2ee95e5c /lib | |
| parent | scsi: BusLogic: Use %X for u32 sized integer rather than %lX (diff) | |
| download | linux-33529018294f1eabc6b5bb2672941165e658e96a.tar.xz linux-33529018294f1eabc6b5bb2672941165e658e96a.zip | |
scsi: qla4xxx: Convert uses of __constant_cpu_to_<foo> to cpu_to_<foo>
The macros cpu_to_le16() and cpu_to_le32() have special cases for
constants. Their __constant_<foo> versions are not required.
On little endian systems, both cpu_to_le16() and __constant_cpu_to_le16()
expand to the same expression. Same is the case with cpu_to_le32().
On big endian systems, cpu_to_le16() expands to __swab16() which has a
__builtin_constant_p check. Similarly, cpu_to_le32() expands to __swab32().
Consequently these macros can be safely used with constants, and hence all
those uses are converted. This was discovered as a part of a checkpatch
evaluation, looking at all reports of WARNING:CONSTANT_CONVERSION error
type.
Link: https://lore.kernel.org/r/20210716112852.24598-1-dwaipayanray1@gmail.com
Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions