diff options
| author | Nicholas Piggin <npiggin@gmail.com> | 2021-11-07 05:51:16 +0100 |
|---|---|---|
| committer | Petr Mladek <pmladek@suse.com> | 2021-11-10 16:12:00 +0100 |
| commit | 5d5e4522a7f404d1a96fd6c703989d32a9c9568d (patch) | |
| tree | f0241bc19c8cc4106ac4d2dff236cd58528ef0e4 /lib | |
| parent | lib/nmi_backtrace: Serialize even messages about idle CPUs (diff) | |
| download | linux-5d5e4522a7f404d1a96fd6c703989d32a9c9568d.tar.xz linux-5d5e4522a7f404d1a96fd6c703989d32a9c9568d.zip | |
printk: restore flushing of NMI buffers on remote CPUs after NMI backtraces
printk from NMI context relies on irq work being raised on the local CPU
to print to console. This can be a problem if the NMI was raised by a
lockup detector to print lockup stack and regs, because the CPU may not
enable irqs (because it is locked up).
Introduce printk_trigger_flush() that can be called another CPU to try
to get those messages to the console, call that where printk_safe_flush
was previously called.
Fixes: 93d102f094be ("printk: remove safe buffers")
Cc: stable@vger.kernel.org # 5.15
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20211107045116.1754411-1-npiggin@gmail.com
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/nmi_backtrace.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/lib/nmi_backtrace.c b/lib/nmi_backtrace.c index f9e89001b52e..199ab201d501 100644 --- a/lib/nmi_backtrace.c +++ b/lib/nmi_backtrace.c @@ -75,6 +75,12 @@ void nmi_trigger_cpumask_backtrace(const cpumask_t *mask, touch_softlockup_watchdog(); } + /* + * Force flush any remote buffers that might be stuck in IRQ context + * and therefore could not run their irq_work. + */ + printk_trigger_flush(); + clear_bit_unlock(0, &backtrace_flag); put_cpu(); } |