summaryrefslogtreecommitdiffstats
path: root/mm/cma.c
diff options
context:
space:
mode:
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>2020-08-31 15:43:18 +0200
committerVinod Koul <vkoul@kernel.org>2020-09-03 12:32:29 +0200
commit6073755886a463a7a7aecdd0abb32a1d38bdb7e6 (patch)
treeb432fa9a3a5c2e787a3c2831062c07843d1aedde /mm/cma.c
parentsoundwire: add definition for maximum number of ports (diff)
downloadlinux-6073755886a463a7a7aecdd0abb32a1d38bdb7e6.tar.xz
linux-6073755886a463a7a7aecdd0abb32a1d38bdb7e6.zip
soundwire: fix port_ready[] dynamic allocation in mipi_disco
The existing code allocates memory for the total number of ports. This only works if the ports are contiguous, but will break if e.g. a Devices uses port0, 1, and 14. The port_ready[] array would contain 3 elements, which would lead to an out-of-bounds access. Conversely in other cases, the wrong port index would be used leading to timeouts on prepare. This can be fixed by allocating for the worst-case of 15 ports (DP0..DP14). In addition since the number is now fixed, we can use an array instead of a dynamic allocation. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Rander Wang <rander.wang@linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> Link: https://lore.kernel.org/r/20200831134318.11443-4-yung-chuan.liao@linux.intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'mm/cma.c')
0 files changed, 0 insertions, 0 deletions