diff options
| author | J. Bruce Fields <bfields@snoopy.citi.umich.edu> | 2007-02-16 10:28:36 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-16 17:14:01 +0100 |
| commit | bec50c47aaf6f1f9247f1860547ab394a0802a4c (patch) | |
| tree | c988f486976a75ae0694a28f127c58b738debe21 /mm/filemap.c | |
| parent | [PATCH] knfsd: nfsd4: acls: don't return explicit mask (diff) | |
| download | linux-bec50c47aaf6f1f9247f1860547ab394a0802a4c.tar.xz linux-bec50c47aaf6f1f9247f1860547ab394a0802a4c.zip | |
[PATCH] knfsd: nfsd4: acls: avoid unnecessary denies
We're inserting deny's between some ACEs in order to enforce posix draft acl
semantics which prevent permissions from accumulating across entries in an
acl.
That's fine, but we're doing that by inserting a deny after *every* allow,
which is overkill. We shouldn't be adding them in places where they actually
make no difference.
Also replaced some helper functions for creating acl entries; I prefer just
assigning directly to the struct fields--it takes a few more lines, but the
field names provide some documentation that I think makes the result easier
understand.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions