summaryrefslogtreecommitdiffstats
path: root/mm/gup.c
diff options
context:
space:
mode:
authorPeter Zijlstra <peterz@infradead.org>2020-11-26 17:21:30 +0100
committerDave Hansen <dave.hansen@linux.intel.com>2022-12-15 19:37:27 +0100
commit1180e732c985ed3c8866d2fd9e02b619848404a0 (patch)
treed7ce6ce20c24e7c941683d8e5816337d9deb6515 /mm/gup.c
parentmm: Rename pmd_read_atomic() (diff)
downloadlinux-1180e732c985ed3c8866d2fd9e02b619848404a0.tar.xz
linux-1180e732c985ed3c8866d2fd9e02b619848404a0.zip
mm/gup: Fix the lockless PMD access
On architectures where the PTE/PMD is larger than the native word size (i386-PAE for example), READ_ONCE() can do the wrong thing. Use pmdp_get_lockless() just like we use ptep_get_lockless(). Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20221022114424.906110403%40infradead.org
Diffstat (limited to 'mm/gup.c')
-rw-r--r--mm/gup.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/gup.c b/mm/gup.c
index fe195d47de74..ff8b22327e16 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2808,7 +2808,7 @@ static int gup_pmd_range(pud_t *pudp, pud_t pud, unsigned long addr, unsigned lo
pmdp = pmd_offset_lockless(pudp, pud, addr);
do {
- pmd_t pmd = READ_ONCE(*pmdp);
+ pmd_t pmd = pmdp_get_lockless(pmdp);
next = pmd_addr_end(addr, end);
if (!pmd_present(pmd))