diff options
author | Michael Chan <mchan@broadcom.com> | 2005-08-26 00:34:29 +0200 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2005-08-30 01:10:29 +0200 |
commit | afdc08b9f9a7174d7912a160f657f39d46379b5e (patch) | |
tree | 04856840d578c029c8c675130ba93bd607bcaa1e /mm/internal.h | |
parent | [IPV4]: Convert FIB Trie to RCU. (diff) | |
download | linux-afdc08b9f9a7174d7912a160f657f39d46379b5e.tar.xz linux-afdc08b9f9a7174d7912a160f657f39d46379b5e.zip |
[BNX2]: Fix rtnl deadlock in bnx2_close
This fixes an rtnl deadlock problem when flush_scheduled_work() is
called from bnx2_close(). In rare cases, linkwatch_event() may be on
the workqueue from a previous close of a different device and it will
try to get the rtnl lock which is already held by dev_close().
The fix is to set a flag if we are in the reset task which is run
from the workqueue. bnx2_close() will loop until the flag is cleared.
As suggested by Jeff Garzik, the loop is changed to call msleep(1)
instead of yield() in the original patch.
flush_scheduled_work() is also moved to bnx2_remove_one() before the
netdev is freed.
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'mm/internal.h')
0 files changed, 0 insertions, 0 deletions