diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2018-08-02 00:57:43 +0200 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2018-08-02 01:05:55 +0200 |
commit | ce1d6f22fa69287f877aca37e275c776ed6e6eb5 (patch) | |
tree | 57219e88517ae70ccbad12da8268422e09a34c81 /mm/kasan/kasan.c | |
parent | Input: i8042 - add Lenovo LaVie Z to the i8042 reset list (diff) | |
download | linux-ce1d6f22fa69287f877aca37e275c776ed6e6eb5.tar.xz linux-ce1d6f22fa69287f877aca37e275c776ed6e6eb5.zip |
Input: elan_i2c_smbus - cast sizeof to int for comparison
Comparing an int to a size, which is unsigned, causes the int to become
unsigned, giving the wrong result. i2c_smbus_read_block_data can return the
result of i2c_smbus_xfer, whih can return a negative error code.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
int x;
expression e,e1;
identifier f;
@@
*x = f(...);
... when != x = e1
when != if (x < 0 || ...) { ... return ...; }
*x < sizeof(e)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'mm/kasan/kasan.c')
0 files changed, 0 insertions, 0 deletions