summaryrefslogtreecommitdiffstats
path: root/mm/maccess.c
diff options
context:
space:
mode:
authorCyrill Gorcunov <gorcunov@gmail.com>2008-08-31 17:25:49 +0200
committerJ. Bruce Fields <bfields@citi.umich.edu>2008-09-01 20:24:24 +0200
commit27df6f25ff218072e0e879a96beeb398a79cdbc8 (patch)
tree92156018e74a963b2abb94bd51a7e7d6b6a72f34 /mm/maccess.c
parentnfsd: fix compound state allocation error handling (diff)
downloadlinux-27df6f25ff218072e0e879a96beeb398a79cdbc8.tar.xz
linux-27df6f25ff218072e0e879a96beeb398a79cdbc8.zip
sunrpc: fix possible overrun on read of /proc/sys/sunrpc/transports
Vegard Nossum reported ---------------------- > I noticed that something weird is going on with /proc/sys/sunrpc/transports. > This file is generated in net/sunrpc/sysctl.c, function proc_do_xprt(). When > I "cat" this file, I get the expected output: > $ cat /proc/sys/sunrpc/transports > tcp 1048576 > udp 32768 > But I think that it does not check the length of the buffer supplied by > userspace to read(). With my original program, I found that the stack was > being overwritten by the characters above, even when the length given to > read() was just 1. David Wagner added (among other things) that copy_to_user could be probably used here. Ingo Oeser suggested to use simple_read_from_buffer() here. The conclusion is that proc_do_xprt doesn't check for userside buffer size indeed so fix this by using Ingo's suggestion. Reported-by: Vegard Nossum <vegard.nossum@gmail.com> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> CC: Ingo Oeser <ioe-lkml@rameria.de> Cc: Neil Brown <neilb@suse.de> Cc: Chuck Lever <chuck.lever@oracle.com> Cc: Greg Banks <gnb@sgi.com> Cc: Tom Tucker <tom@opengridcomputing.com> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'mm/maccess.c')
0 files changed, 0 insertions, 0 deletions