diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2012-01-14 06:32:59 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2012-01-24 21:12:32 +0100 |
| commit | ce597919361dcec97341151690e780eade2a9cf4 (patch) | |
| tree | 7734c3d6a07173cb509be7a2ac7318fd389510bb /mm/memblock.c | |
| parent | stable: update documentation to ask for kernel version (diff) | |
| download | linux-ce597919361dcec97341151690e780eade2a9cf4.tar.xz linux-ce597919361dcec97341151690e780eade2a9cf4.zip | |
sysfs: Complain bitterly about attempts to remove files from nonexistent directories.
Recently an OOPS was observed from the usb serial io_ti driver when it tried to remove
sysfs directories. Upon investigation it turns out this driver was always buggy
and that a recent sysfs change had stopped guarding itself against removing attributes
from sysfs directories that had already been removed. :(
Historically we have been silent about attempting to files from nonexistent sysfs
directories and have politely returned error codes. That has resulted in people writing
broken code that ignores the error codes.
Issue a kernel WARNING and a stack backtrace to make it clear in no uncertain
terms that abusing sysfs is not ok, and the callers need to fix their code.
This change transforms the io_ti OOPS into a more comprehensible error message
and stack backtrace.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Reported-by: Wolfgang Frisch <wfpub@roembden.net>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'mm/memblock.c')
0 files changed, 0 insertions, 0 deletions