summaryrefslogtreecommitdiffstats
path: root/mm/memcontrol.c
diff options
context:
space:
mode:
authorRoman Gushchin <guro@fb.com>2017-09-07 01:21:47 +0200
committerLinus Torvalds <torvalds@linux-foundation.org>2017-09-07 02:27:27 +0200
commit63677c745d63ba75ef97a7728c85168ddd6c0040 (patch)
treeea5d002ac8e56590d68b0b11d1fc0b62dac1b0a1 /mm/memcontrol.c
parentmm: remove nr_pages argument from pagevec_lookup{,_range}() (diff)
downloadlinux-63677c745d63ba75ef97a7728c85168ddd6c0040.tar.xz
linux-63677c745d63ba75ef97a7728c85168ddd6c0040.zip
mm, memcg: reset memory.low during memcg offlining
A removed memory cgroup with a defined memory.low and some belonging pagecache has very low chances to be freed. If a cgroup has been removed, there is likely no memory pressure inside the cgroup, and the pagecache is protected from the external pressure by the defined low limit. The cgroup will be freed only after the reclaim of all belonging pages. And it will not happen until there are any reclaimable memory in the system. That means, there is a good chance, that a cold pagecache will reside in the memory for an undefined amount of time, wasting system resources. This problem was fixed earlier by fa06235b8eb0 ("cgroup: reset css on destruction"), but it's not a best way to do it, as we can't really reset all limits/counters during cgroup offlining. Link: http://lkml.kernel.org/r/20170727130428.28856-1-guro@fb.com Signed-off-by: Roman Gushchin <guro@fb.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Vladimir Davydov <vdavydov.dev@gmail.com> Cc: Tejun Heo <tj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/memcontrol.c')
-rw-r--r--mm/memcontrol.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index e09741af816f..2926c44519b6 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4319,6 +4319,8 @@ static void mem_cgroup_css_offline(struct cgroup_subsys_state *css)
}
spin_unlock(&memcg->event_list_lock);
+ memcg->low = 0;
+
memcg_offline_kmem(memcg);
wb_memcg_offline(memcg);