diff options
| author | Miaohe Lin <linmiaohe@huawei.com> | 2022-04-29 08:16:02 +0200 |
|---|---|---|
| committer | akpm <akpm@linux-foundation.org> | 2022-04-29 08:16:02 +0200 |
| commit | 3f871370686ddf3c72207321eef8f6672ae957e4 (patch) | |
| tree | adef1e45a225cc0a5d36edf42bd22c0ef6a19fe9 /mm/memory-failure.c | |
| parent | Revert "mm/memory-failure.c: fix race with changing page compound again" (diff) | |
| download | linux-3f871370686ddf3c72207321eef8f6672ae957e4.tar.xz linux-3f871370686ddf3c72207321eef8f6672ae957e4.zip | |
mm/memory-failure.c: minor cleanup for HWPoisonHandlable
Patch series "A few fixup and cleanup patches for memory failure", v2.
This series contains a patch to clean up the HWPoisonHandlable and another
one to dissolve truncated hugetlb page. More details can be found in the
respective changelogs.
This patch (of 2):
The local variable movable can be removed by returning true directly. Also
fix typo 'mirgate'. No functional change intended.
Link: https://lkml.kernel.org/r/20220414114941.11223-1-linmiaohe@huawei.com
Link: https://lkml.kernel.org/r/20220414114941.11223-2-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | mm/memory-failure.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 8af37f76e7ba..48815e1af645 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1178,13 +1178,11 @@ void ClearPageHWPoisonTakenOff(struct page *page) */ static inline bool HWPoisonHandlable(struct page *page, unsigned long flags) { - bool movable = false; - - /* Soft offline could mirgate non-LRU movable pages */ + /* Soft offline could migrate non-LRU movable pages */ if ((flags & MF_SOFT_OFFLINE) && __PageMovable(page)) - movable = true; + return true; - return movable || PageLRU(page) || is_free_buddy_page(page); + return PageLRU(page) || is_free_buddy_page(page); } static int __get_hwpoison_page(struct page *page, unsigned long flags) |