summaryrefslogtreecommitdiffstats
path: root/mm/page-writeback.c
diff options
context:
space:
mode:
authorKonstantin Khebnikov <khlebnikov@yandex-team.ru>2015-02-12 00:26:55 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2015-02-12 02:06:04 +0100
commit8d38633c3b4093aca7524945f1e9249d7d3a44da (patch)
treec2220d43cd690f94dccb8d0f4917199ed5689a9c /mm/page-writeback.c
parentmm: fix false-positive warning on exit due mm_nr_pmds(mm) (diff)
downloadlinux-8d38633c3b4093aca7524945f1e9249d7d3a44da.tar.xz
linux-8d38633c3b4093aca7524945f1e9249d7d3a44da.zip
page_writeback: put account_page_redirty() after set_page_dirty()
Helper account_page_redirty() fixes dirty pages counter for redirtied pages. This patch puts it after dirtying and prevents temporary underflows of dirtied pages counters on zone/bdi and current->nr_dirtied. Signed-off-by: Konstantin Khebnikov <khlebnikov@yandex-team.ru> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
-rw-r--r--mm/page-writeback.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index fb71e9deca85..6a73e47e81c6 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -2168,9 +2168,12 @@ EXPORT_SYMBOL(account_page_redirty);
*/
int redirty_page_for_writepage(struct writeback_control *wbc, struct page *page)
{
+ int ret;
+
wbc->pages_skipped++;
+ ret = __set_page_dirty_nobuffers(page);
account_page_redirty(page);
- return __set_page_dirty_nobuffers(page);
+ return ret;
}
EXPORT_SYMBOL(redirty_page_for_writepage);