diff options
| author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2009-06-25 21:31:37 +0200 |
|---|---|---|
| committer | Pekka Enberg <penberg@cs.helsinki.fi> | 2009-06-26 11:10:47 +0200 |
| commit | 7ed9f7e5db58c6e8c2b4b738a75d5dcd8e17aad5 (patch) | |
| tree | c8ee9b63e1e8d3925b8a08a2b21a331434d183b5 /mm/slub.c | |
| parent | Linux 2.6.31-rc1 (diff) | |
| download | linux-7ed9f7e5db58c6e8c2b4b738a75d5dcd8e17aad5.tar.xz linux-7ed9f7e5db58c6e8c2b4b738a75d5dcd8e17aad5.zip | |
fix RCU-callback-after-kmem_cache_destroy problem in sl[aou]b
Jesper noted that kmem_cache_destroy() invokes synchronize_rcu() rather than
rcu_barrier() in the SLAB_DESTROY_BY_RCU case, which could result in RCU
callbacks accessing a kmem_cache after it had been destroyed.
Cc: <stable@kernel.org>
Acked-by: Matt Mackall <mpm@selenic.com>
Reported-by: Jesper Dangaard Brouer <hawk@comx.dk>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Diffstat (limited to 'mm/slub.c')
| -rw-r--r-- | mm/slub.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/mm/slub.c b/mm/slub.c index 819f056b39c6..a9201d83178b 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2595,6 +2595,8 @@ static inline int kmem_cache_close(struct kmem_cache *s) */ void kmem_cache_destroy(struct kmem_cache *s) { + if (s->flags & SLAB_DESTROY_BY_RCU) + rcu_barrier(); down_write(&slub_lock); s->refcount--; if (!s->refcount) { |