diff options
| author | Nick Piggin <npiggin@suse.de> | 2008-10-19 05:26:59 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-10-20 17:52:32 +0200 |
| commit | 8413ac9d8c9a1366a4f57880723126cd24e5a5c3 (patch) | |
| tree | fcee6ff670dcfccf895a48e92d27f52902d34301 /mm/swapfile.c | |
| parent | mm: unlockless reclaim (diff) | |
| download | linux-8413ac9d8c9a1366a4f57880723126cd24e5a5c3.tar.xz linux-8413ac9d8c9a1366a4f57880723126cd24e5a5c3.zip | |
mm: page lock use lock bitops
trylock_page, unlock_page open and close a critical section. Hence,
we can use the lock bitops to get the desired memory ordering.
Also, mark trylock as likely to succeed (and remove the annotation from
callers).
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/swapfile.c')
| -rw-r--r-- | mm/swapfile.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/swapfile.c b/mm/swapfile.c index 2a97fafa3d89..90cb67a5417c 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -422,7 +422,7 @@ void free_swap_and_cache(swp_entry_t entry) if (p) { if (swap_entry_free(p, swp_offset(entry)) == 1) { page = find_get_page(&swapper_space, entry.val); - if (page && unlikely(!trylock_page(page))) { + if (page && !trylock_page(page)) { page_cache_release(page); page = NULL; } |