diff options
| author | Thomas Meyer <thomas@m3y3r.de> | 2012-05-30 00:06:21 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-30 01:22:19 +0200 |
| commit | 4d67d860531ad5378dedfad7661c540f3365013d (patch) | |
| tree | 751f06891f6ffa0aaac13090e84010f26a612056 /mm/vmalloc.c | |
| parent | mm: fix off-by-one bug in print_nodes_state() (diff) | |
| download | linux-4d67d860531ad5378dedfad7661c540f3365013d.tar.xz linux-4d67d860531ad5378dedfad7661c540f3365013d.zip | |
mm: use kcalloc() instead of kzalloc() to allocate array
The advantage of kcalloc is, that will prevent integer overflows which
could result from the multiplication of number of elements and size and
it is also a bit nicer to read.
The semantic patch that makes this change is available in
https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/vmalloc.c')
| -rw-r--r-- | mm/vmalloc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 94dff883b449..c28b0b9e5cc0 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2375,8 +2375,8 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, return NULL; } - vms = kzalloc(sizeof(vms[0]) * nr_vms, GFP_KERNEL); - vas = kzalloc(sizeof(vas[0]) * nr_vms, GFP_KERNEL); + vms = kcalloc(nr_vms, sizeof(vms[0]), GFP_KERNEL); + vas = kcalloc(nr_vms, sizeof(vas[0]), GFP_KERNEL); if (!vas || !vms) goto err_free2; |