diff options
| author | Sergey Senozhatsky <sergey.senozhatsky@gmail.com> | 2015-06-10 20:14:57 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-06-11 01:43:43 +0200 |
| commit | 02f7b4145da113683ad64c74bf64605e16b71789 (patch) | |
| tree | f3b5f68fdd7bf92d29e615284b28739d55abc089 /mm/zsmalloc.c | |
| parent | mm: memcontrol: fix false-positive VM_BUG_ON() on -rt (diff) | |
| download | linux-02f7b4145da113683ad64c74bf64605e16b71789.tar.xz linux-02f7b4145da113683ad64c74bf64605e16b71789.zip | |
zsmalloc: fix a null pointer dereference in destroy_handle_cache()
If zs_create_pool()->create_handle_cache()->kmem_cache_create() or
pool->name allocation fails, zs_create_pool()->destroy_handle_cache()
will dereference the NULL pool->handle_cachep.
Modify destroy_handle_cache() to avoid this.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | mm/zsmalloc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 08bd7a3d464a..a8b5e749e84e 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -289,7 +289,8 @@ static int create_handle_cache(struct zs_pool *pool) static void destroy_handle_cache(struct zs_pool *pool) { - kmem_cache_destroy(pool->handle_cachep); + if (pool->handle_cachep) + kmem_cache_destroy(pool->handle_cachep); } static unsigned long alloc_handle(struct zs_pool *pool) |