diff options
| author | Andrea Arcangeli <aarcange@redhat.com> | 2010-08-10 02:19:08 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-08-10 05:44:58 +0200 |
| commit | 26ba0cb63cb8df4e45394227f33c938920b11b88 (patch) | |
| tree | 131b785dc7fb0102ee4fc4f56a1ae948b9861501 /mm | |
| parent | mmap: remove unnecessary lock from __vma_link (diff) | |
| download | linux-26ba0cb63cb8df4e45394227f33c938920b11b88.tar.xz linux-26ba0cb63cb8df4e45394227f33c938920b11b88.zip | |
rmap: always add new vmas at the end
Make sure to always add new VMAs at the end of the list. This is
important so rmap_walk does not miss a VMA that was created during the
rmap_walk.
The old code got this right most of the time due to luck, but was buggy
when anon_vma_prepare reused a mergeable anon_vma.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/rmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/rmap.c b/mm/rmap.c index 07e9814c7a41..dce74a9efdd6 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -147,7 +147,7 @@ int anon_vma_prepare(struct vm_area_struct *vma) avc->anon_vma = anon_vma; avc->vma = vma; list_add(&avc->same_vma, &vma->anon_vma_chain); - list_add(&avc->same_anon_vma, &anon_vma->head); + list_add_tail(&avc->same_anon_vma, &anon_vma->head); allocated = NULL; avc = NULL; } |