diff options
author | Tejun Heo <tj@kernel.org> | 2011-06-02 11:14:00 +0200 |
---|---|---|
committer | Oleg Nesterov <oleg@redhat.com> | 2011-06-04 18:17:11 +0200 |
commit | 62c124ff3bcdb414af635c2bf822c9e4f2a5abfa (patch) | |
tree | 5d279211e098d24245d49e394d84aa8cfdb6f277 /mm | |
parent | job control: introduce task_set_jobctl_pending() (diff) | |
download | linux-62c124ff3bcdb414af635c2bf822c9e4f2a5abfa.tar.xz linux-62c124ff3bcdb414af635c2bf822c9e4f2a5abfa.zip |
ptrace: use bit_waitqueue for TRAPPING instead of wait_chldexit
ptracer->signal->wait_chldexit was used to wait for TRAPPING; however,
->wait_chldexit was already complicated with waker-side filtering
without adding TRAPPING wait on top of it. Also, it unnecessarily
made TRAPPING clearing depend on the current ptrace relationship - if
the ptracee is detached, wakeup is lost.
There is no reason to use signal->wait_chldexit here. We're just
waiting for JOBCTL_TRAPPING bit to clear and given the relatively
infrequent use of ptrace, bit_waitqueue can serve it perfectly.
This patch makes JOBCTL_TRAPPING wait use bit_waitqueue instead of
signal->wait_chldexit.
-v2: Use JOBCTL_*_BIT macros instead of ilog2() as suggested by Linus.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions