diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-05-09 05:35:55 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-05-09 20:41:40 +0200 |
| commit | da37e368763f708d2ae5a81e61ec59372b831cf5 (patch) | |
| tree | 0ee4b0509caca004aee6a69000d69d67c8bc0eef /net/802/garp.c | |
| parent | net: use batched device unregister in veth and macvlan (diff) | |
| download | linux-da37e368763f708d2ae5a81e61ec59372b831cf5.tar.xz linux-da37e368763f708d2ae5a81e61ec59372b831cf5.zip | |
garp: remove one synchronize_rcu() call
Speedup vlan dismantling in CONFIG_VLAN_8021Q_GVRP=y cases,
by using a call_rcu() to free the memory instead of waiting with
expensive synchronize_rcu() [ while RTNL is held ]
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ben Greear <greearb@candelatech.com>
Cc: Patrick McHardy <kaber@trash.net>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/802/garp.c')
| -rw-r--r-- | net/802/garp.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/net/802/garp.c b/net/802/garp.c index c1df2dad8c6b..5dbe8967bbd5 100644 --- a/net/802/garp.c +++ b/net/802/garp.c @@ -544,6 +544,11 @@ static int garp_init_port(struct net_device *dev) return 0; } +static void garp_kfree_rcu(struct rcu_head *head) +{ + kfree(container_of(head, struct garp_port, rcu)); +} + static void garp_release_port(struct net_device *dev) { struct garp_port *port = rtnl_dereference(dev->garp_port); @@ -554,8 +559,7 @@ static void garp_release_port(struct net_device *dev) return; } rcu_assign_pointer(dev->garp_port, NULL); - synchronize_rcu(); - kfree(port); + call_rcu(&port->rcu, garp_kfree_rcu); } int garp_init_applicant(struct net_device *dev, struct garp_application *appl) |