diff options
| author | Patrick McHardy <kaber@trash.net> | 2008-07-08 12:24:44 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-07-08 12:24:44 +0200 |
| commit | 9bb8582efb555521c7eec595ebd34e835ddc34b8 (patch) | |
| tree | 8eb6aae062bbd359e820a35d51fb16a32e7b828f /net/8021q/vlan_gvrp.c | |
| parent | vlan: remove useless struct hlist_node declaration from if_vlan.h (diff) | |
| download | linux-9bb8582efb555521c7eec595ebd34e835ddc34b8.tar.xz linux-9bb8582efb555521c7eec595ebd34e835ddc34b8.zip | |
vlan: TCI related type and naming cleanups
The VLAN code contains multiple spots that use tag, id and tci as
identifiers for arguments and variables incorrectly and they actually
contain or are expected to contain something different. Additionally
types are used inconsistently (unsigned short vs u16) and identifiers
are sometimes capitalized.
- consistently use u16 for storing TCI, ID or QoS values
- consistently use vlan_id and vlan_tci for storing the respective values
- remove capitalization
- add kdoc comment to netif_hwaccel_{rx,receive_skb}
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q/vlan_gvrp.c')
| -rw-r--r-- | net/8021q/vlan_gvrp.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/net/8021q/vlan_gvrp.c b/net/8021q/vlan_gvrp.c index db9781608362..061ceceeef12 100644 --- a/net/8021q/vlan_gvrp.c +++ b/net/8021q/vlan_gvrp.c @@ -30,19 +30,19 @@ static struct garp_application vlan_gvrp_app __read_mostly = { int vlan_gvrp_request_join(const struct net_device *dev) { const struct vlan_dev_info *vlan = vlan_dev_info(dev); - __be16 vid = htons(vlan->vlan_id); + __be16 vlan_id = htons(vlan->vlan_id); return garp_request_join(vlan->real_dev, &vlan_gvrp_app, - &vid, sizeof(vid), GVRP_ATTR_VID); + &vlan_id, sizeof(vlan_id), GVRP_ATTR_VID); } void vlan_gvrp_request_leave(const struct net_device *dev) { const struct vlan_dev_info *vlan = vlan_dev_info(dev); - __be16 vid = htons(vlan->vlan_id); + __be16 vlan_id = htons(vlan->vlan_id); garp_request_leave(vlan->real_dev, &vlan_gvrp_app, - &vid, sizeof(vid), GVRP_ATTR_VID); + &vlan_id, sizeof(vlan_id), GVRP_ATTR_VID); } int vlan_gvrp_init_applicant(struct net_device *dev) |