summaryrefslogtreecommitdiffstats
path: root/net/appletalk
diff options
context:
space:
mode:
authorNeil Horman <nhorman@tuxdriver.com>2010-01-15 10:40:55 +0100
committerDavid S. Miller <davem@davemloft.net>2010-01-15 10:40:55 +0100
commit38ff3e6bb987ec583268da8eb22628293095d43b (patch)
treee19ee438e49717cb412686a1828f32e6b786ceab /net/appletalk
parentnet: fix build erros with CONFIG_BUG=n, CONFIG_GENERIC_BUG=n (diff)
downloadlinux-38ff3e6bb987ec583268da8eb22628293095d43b.tar.xz
linux-38ff3e6bb987ec583268da8eb22628293095d43b.zip
dccp_probe: Fix module load dependencies between dccp and dccp_probe
This was just recently reported to me. When built as modules, the dccp_probe module has a silent dependency on the dccp module. This stems from the fact that the module_init routine of dccp_probe registers a jprobe on the dccp_sendmsg symbol. Since the symbol is only referenced as a text string (the .symbol_name field in the jprobe struct) rather than the address of the symbol itself, depmod never picks this dependency up, and so if you load the dccp_probe module without the dccp module loaded, the register_jprobe call fails with an -EINVAL, and the whole module load fails. The fix is pretty easy, we can just wrap the register_jprobe call in a try_then_request_module call, which forces the dependency to get satisfied prior to the probe registration. Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/appletalk')
0 files changed, 0 insertions, 0 deletions