diff options
| author | Sergey Shtylyov <s.shtylyov@omp.ru> | 2023-10-19 12:29:23 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-10-21 12:38:54 +0200 |
| commit | a5f928db59519a15e82ecba4ae3e7cbf5a44715a (patch) | |
| tree | b1840d98a6cf9efa93a7243bdbb36a85ec390a46 /net/batman-adv/soft-interface.c | |
| parent | usb: xhci: Implement xhci_handshake_check_state() helper (diff) | |
| download | linux-a5f928db59519a15e82ecba4ae3e7cbf5a44715a.tar.xz linux-a5f928db59519a15e82ecba4ae3e7cbf5a44715a.zip | |
usb: host: xhci-plat: fix possible kernel oops while resuming
If this driver enables the xHC clocks while resuming from sleep, it calls
clk_prepare_enable() without checking for errors and blithely goes on to
read/write the xHC's registers -- which, with the xHC not being clocked,
at least on ARM32 usually causes an imprecise external abort exceptions
which cause kernel oops. Currently, the chips for which the driver does
the clock dance on suspend/resume seem to be the Broadcom STB SoCs, based
on ARM32 CPUs, as it seems...
Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.
Fixes: 8bd954c56197 ("usb: host: xhci-plat: suspend and resume clocks")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20231019102924.2797346-19-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/batman-adv/soft-interface.c')
0 files changed, 0 insertions, 0 deletions