summaryrefslogtreecommitdiffstats
path: root/net/batman-adv/soft-interface.h
diff options
context:
space:
mode:
authorSven Eckelmann <sven@narfation.org>2016-03-20 12:27:53 +0100
committerAntonio Quartulli <a@unstable.cc>2016-04-24 09:41:25 +0200
commitd1a65f1741bfd9c69f9e4e2ad447a89b6810427d (patch)
treea5d658274874bb05bca55c123e3193a61db187ee /net/batman-adv/soft-interface.h
parentbatman-adv: Deactivate TO_BE_ACTIVATED hardif on shutdown (diff)
downloadlinux-d1a65f1741bfd9c69f9e4e2ad447a89b6810427d.tar.xz
linux-d1a65f1741bfd9c69f9e4e2ad447a89b6810427d.zip
batman-adv: Reduce refcnt of removed router when updating route
_batadv_update_route rcu_derefences orig_ifinfo->router outside of a spinlock protected region to print some information messages to the debug log. But this pointer is not checked again when the new pointer is assigned in the spinlock protected region. Thus is can happen that the value of orig_ifinfo->router changed in the meantime and thus the reference counter of the wrong router gets reduced after the spinlock protected region. Just rcu_dereferencing the value of orig_ifinfo->router inside the spinlock protected region (which also set the new pointer) is enough to get the correct old router object. Fixes: e1a5382f978b ("batman-adv: Make orig_node->router an rcu protected pointer") Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch> Signed-off-by: Antonio Quartulli <a@unstable.cc>
Diffstat (limited to 'net/batman-adv/soft-interface.h')
0 files changed, 0 insertions, 0 deletions