diff options
| author | Jaganath Kanakkassery <jaganath.k.os@gmail.com> | 2017-10-25 07:28:48 +0200 |
|---|---|---|
| committer | Marcel Holtmann <marcel@holtmann.org> | 2017-10-29 14:07:10 +0100 |
| commit | f17d858ed0a48270db4368d8cf370e3839ee6f4f (patch) | |
| tree | 975b67fd9b1bf35c27320b25f11b8fa508d69a12 /net/bluetooth/hci_conn.c | |
| parent | Bluetooth: btusb: Add new NFA344A entry. (diff) | |
| download | linux-f17d858ed0a48270db4368d8cf370e3839ee6f4f.tar.xz linux-f17d858ed0a48270db4368d8cf370e3839ee6f4f.zip | |
Bluetooth: Fix potential memory leak
If command is added to req then it should be freed in case if
hdev is down or HCI_ADVERTISING flag is set.
This introduces a helper in hci_request to purge the cmd_q
to make cmd_q internal to hci_request which is used to fix
the leak.
This also replace accessing of cmd_q in hci_conn with the
new helper.
Signed-off-by: Jaganath Kanakkassery <jaganathx.kanakkassery@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'net/bluetooth/hci_conn.c')
| -rw-r--r-- | net/bluetooth/hci_conn.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c index dc59eae54717..746adcb62259 100644 --- a/net/bluetooth/hci_conn.c +++ b/net/bluetooth/hci_conn.c @@ -907,7 +907,7 @@ struct hci_conn *hci_connect_le(struct hci_dev *hdev, bdaddr_t *dst, */ if (hci_dev_test_flag(hdev, HCI_LE_SCAN) && hdev->le_scan_type == LE_SCAN_ACTIVE) { - skb_queue_purge(&req.cmd_q); + hci_req_purge(&req); hci_conn_del(conn); return ERR_PTR(-EBUSY); } |