diff options
| author | stephen hemminger <shemminger@vyatta.com> | 2012-12-28 19:15:22 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-12-30 11:31:43 +0100 |
| commit | 576eb62598f10c8c7fd75703fe89010cdcfff596 (patch) | |
| tree | 47317f7bc68dc06ad06735eb7c9ba4e271dcd793 /net/bridge/br_netlink.c | |
| parent | net: filter: return -EINVAL if BPF_S_ANC* operation is not supported (diff) | |
| download | linux-576eb62598f10c8c7fd75703fe89010cdcfff596.tar.xz linux-576eb62598f10c8c7fd75703fe89010cdcfff596.zip | |
bridge: respect RFC2863 operational state
The bridge link detection should follow the operational state
of the lower device, rather than the carrier bit. This allows devices
like tunnels that are controlled by userspace control plane to work
with bridge STP link management.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Reviewed-by: Flavio Leitner <fbl@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_netlink.c')
| -rw-r--r-- | net/bridge/br_netlink.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 97ba0189c6f7..caa3f6919436 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -181,8 +181,11 @@ static int br_set_port_state(struct net_bridge_port *p, u8 state) if (p->br->stp_enabled == BR_KERNEL_STP) return -EBUSY; + /* if device is not up, change is not allowed + * if link is not present, only allowable state is disabled + */ if (!netif_running(p->dev) || - (!netif_carrier_ok(p->dev) && state != BR_STATE_DISABLED)) + (!netif_oper_up(p->dev) && state != BR_STATE_DISABLED)) return -ENETDOWN; p->state = state; |