diff options
| author | Scott Feldman <sfeldma@gmail.com> | 2015-10-09 04:23:19 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-10-12 14:20:20 +0200 |
| commit | c62987bbd8a1a1664f99e89e3959339350a6131e (patch) | |
| tree | 3a7455b6ab6b25335c709662b078c2375b700900 /net/bridge/br_netlink.c | |
| parent | switchdev: skip over ports returning -EOPNOTSUPP when recursing ports (diff) | |
| download | linux-c62987bbd8a1a1664f99e89e3959339350a6131e.tar.xz linux-c62987bbd8a1a1664f99e89e3959339350a6131e.zip | |
bridge: push bridge setting ageing_time down to switchdev
Use SWITCHDEV_F_SKIP_EOPNOTSUPP to skip over ports in bridge that don't
support setting ageing_time (or setting bridge attrs in general).
If push fails, don't update ageing_time in bridge and return err to user.
If push succeeds, update ageing_time in bridge and run gc_timer now to
recalabrate when to run gc_timer next, based on new ageing_time.
Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_netlink.c')
| -rw-r--r-- | net/bridge/br_netlink.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index d78b4429505a..544ab966d477 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -870,9 +870,9 @@ static int br_changelink(struct net_device *brdev, struct nlattr *tb[], } if (data[IFLA_BR_AGEING_TIME]) { - u32 ageing_time = nla_get_u32(data[IFLA_BR_AGEING_TIME]); - - br->ageing_time = clock_t_to_jiffies(ageing_time); + err = br_set_ageing_time(br, nla_get_u32(data[IFLA_BR_AGEING_TIME])); + if (err) + return err; } if (data[IFLA_BR_STP_STATE]) { |